Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update firewalld.py #64153

Merged
merged 1 commit into from Nov 5, 2019
Merged

Update firewalld.py #64153

merged 1 commit into from Nov 5, 2019

Conversation

stevenamelinckx
Copy link
Contributor

SUMMARY

state should be "enabled" and not "present"
When running the example you get the following error:
"msg: absent and present state can only be used in zone level operations"

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@stevenamelinckx
Update firewalld.py
d1ccb9f 
##### SUMMARY
state should be "enabled" and not "present"
When running the example you get the following error:
  "msg: absent and present state can only be used in zone level operations"


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Oct 31, 2019

cc @maxamillion
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. system System category labels Oct 31, 2019
@samccann samccann merged commit e704406 into ansible:devel Nov 5, 2019
@samccann samccann removed the needs_triage Needs a first human triage before being processed. label Nov 5, 2019
@samccann
Copy link
Contributor

samccann commented Nov 5, 2019

Thanks @stevenamelinckx for the Ansible documentation fix!

@ansible ansible locked and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann approved these changes

@maxamillion maxamillion Awaiting requested review from maxamillion

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevenamelinckx @ansibot @samccann