Replace clear() method for backward compatibility.

[n0trax]

SUMMARY

The clear() method is only supported from python >= 3.3, but acme_certificate has python >=2.6 as requirement. Therefore we should replace the clear() method.

Fixes #64501

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

acme_certificate

[ansibot]

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @felixfontein @mgruener @puiterwijk @resmo
click here for bot help

[felixfontein]

Thanks for spotting this! Unfortunately the integration tests didn't catch this since they don't use ACME v1... BTW, out of curiosity: why are you still using ACME v1? Is it because you didn't upgrade yet, or because the ACME server you're using doesn't support ACME v2? (Edit: from your example in #64501 I see you're using Let's Encrypt. Please note that Let's Encrypt deprecated ACME v1 and will remove it eventually.)

In any case, you need a changelog fragment:

bugfixes:
- "acme_certificate - fix crash when module is used with Python 2.x."

[felixfontein]

(In case you're interested, Let's Encrypt's ACME v1 deprecation.)

[MarkusTeufelberger]

lgtm

[n0trax]

@felixfontein the task uses the ACMEv1 because it is an older playbook and the default acme_version of the acme_certificate module is still ACMEv1.
But thanks for the hint :-) I updated my letsEncrypt playbook to use ACMEv2.

I also added the changelog fragment.

[felixfontein]

shipit

[felixfontein]

@n0trax thanks for reporting and fixing this! I'll create backport PRs so this will also get fixed in 2.8.x and 2.9.x eventually.
@MarkusTeufelberger thanks for reviewing!

@n0trax actually the default for acme_version will change eventually; from Ansible 2.10 on you'll get a warning if you don't specify it, with a note that there will no longer be a default for Ansible 2.14. From then on, you'll have to specify the version explicitly.

[felixfontein]

(Just noticed, no backport necessary to stable-2.8 since that doesn't happen in Ansible 2.8.x. The broken code was new for 2.9.0.)