Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redfish_command - failure on user account deletion #64684

Closed
spike77453 opened this issue Nov 11, 2019 · 9 comments · Fixed by #64797
Closed

redfish_command - failure on user account deletion #64684

spike77453 opened this issue Nov 11, 2019 · 9 comments · Fixed by #64797
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. has_pr This issue has an associated PR. module This issue/PR relates to a module. remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html support:community This issue/PR relates to code supported by the Ansible community.

Comments

@spike77453
Copy link
Contributor

SUMMARY

Running the example playbook from https://docs.ansible.com/ansible/latest/modules/redfish_command_module.html#examples to disable and delete a certain user works as expected, but results in an error message

The specified value is not allowed to be configured if the user name \nor password is blank.'

Note that the user to be deleted (in the example below the user with id 5) is different from the user specified in "username".
The user (in the example below the user with id 5) is deleted as expected despite the error message.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

redfish_command

ANSIBLE VERSION
ansible 2.10.0.dev0
  config file = /home/ansible/ansible_local/ansible.cfg
  configured module search path = [u'/home/ansible/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Aug  7 2019, 00:51:29) [GCC 4.8.5 20150623 (Red Hat 4.8.5-39)]
CONFIGURATION

OS / ENVIRONMENT

CentOS Linux release 7.6.1810 (Core)
Dell R640, iDRAC Firmware 3.32.32.32

STEPS TO REPRODUCE
- name: Disable and delete user
  hosts: dellR640
  gather_facts: False
  tasks:
    - name: Disable and delete user with id 5
      local_action:
        module: redfish_command
        category: Accounts
        command: ["DisableUser", "DeleteUser"]
        baseuri: "{{ baseuri }}"
        username: "{{ username }}"
        password: "{{ password }}"
        id: "5"
EXPECTED RESULTS
ACTUAL RESULTS
fatal: [dellR640 -> localhost]: FAILED! => {
    "changed": false, 
    "invocation": {
        "module_args": {
            "account_properties": {}, 
            "baseuri": "dellR640idrac", 
            "boot_next": null, 
            "bootdevice": null, 
            "category": "Accounts", 
            "command": [
                "DisableUser", 
                "DeleteUser"
            ], 
            "id": "5", 
            "new_password": null, 
            "new_username": null, 
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", 
            "resource_id": null, 
            "roleid": null, 
            "timeout": 10, 
            "uefi_target": null, 
            "update_username": null, 
            "username": "customadminuser"
        }
    }, 
    "msg": "HTTP Error 400 on PATCH request to 'https://dellR640idrac/redfish/v1/Managers/iDRAC.Embedded.1/Accounts/5', extended message: 'The specified value is not allowed to be configured if the user name \\nor password is blank.'"
}
@spike77453 spike77453 changed the title redfish_command - failure on user accout deletion redfish_command - failure on user account deletion Nov 11, 2019
@ansibot
Copy link
Contributor

ansibot commented Nov 11, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 11, 2019

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html support:community This issue/PR relates to code supported by the Ansible community. labels Nov 11, 2019
@billdodd
Copy link
Contributor

@spike77453 I haven't been able to reproduce this error on the Dell R630 I have access to. And I do not have access to an R640.

I do have a suspicion of what may be causing it and a potential fix idea. If I create a PR with a potential fix, would you be willing and able to test it?

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Nov 12, 2019
@spike77453
Copy link
Contributor Author

@billdodd Sure thing. I'm happy to test any potential fix. Just let me know.

@billdodd
Copy link
Contributor

Sure thing. I'm happy to test any potential fix. Just let me know.

Thanks! PR is ready to test: #64797

@ansibot ansibot added the has_pr This issue has an associated PR. label Nov 13, 2019
@spike77453
Copy link
Contributor Author

#64797 works for me. Thanks a bunch!

@billdodd
Copy link
Contributor

@spike77453 Great! Thanks for testing.

Would you mind re-opening the issue? That way the core team will see that my PR is to fix an open issue and will be sure to merge it. Otherwise, there might be some confusion if the issue is already closed. :-) Once the PR is merged, your issue will be automatically closed.

@spike77453 spike77453 reopened this Nov 13, 2019
@spike77453
Copy link
Contributor Author

Would you mind re-opening the issue? That way the core team will see that my PR is to fix an open issue and will be sure to merge it.

Sorry, wasn't aware that it's still needed.

@billdodd
Copy link
Contributor

No worries. Thanks again.

@ansible ansible locked and limited conversation to collaborators Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. has_pr This issue has an associated PR. module This issue/PR relates to a module. remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants