Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use context manager for mssql and postgresql modules. #65224

Merged
merged 1 commit into from Nov 29, 2019
Merged

Use context manager for mssql and postgresql modules. #65224

merged 1 commit into from Nov 29, 2019

Conversation

atombrella
Copy link
Contributor

@atombrella atombrella commented Nov 23, 2019 •
edited

SUMMARY

Something that wasn't included in #63840 It should be quite safe, i.e., no semantic changes.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

database, mssql, postfix, system, core.

ADDITIONAL INFORMATION

There are some things in the postgresql module that are less trivial to change. I'll do them in a future PR.

@ansibot
Copy link
Contributor

ansibot commented Nov 23, 2019

cc @Andersson007 @Dorn- @Jmainguy @amenonsen @andytom @jbscalia @kenichi-ogawa-1988 @kostiantyn-nemchenko @matburt @nerzhul @sebasmannem @tcraxs @vedit
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. database Database category module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. labels Nov 23, 2019
@sebasmannem
Copy link
Contributor

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Nov 28, 2019
Andersson007
Andersson007 approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 29, 2019
@ansibot ansibot merged commit d335d7a into ansible:devel Nov 29, 2019
@Andersson007
Copy link
Contributor

@atombrella thanks for the contribution!
@sebasmannem thanks for reviewing!

@atombrella atombrella deleted the database_ctx_man branch November 29, 2019 08:10
tcraxs
tcraxs approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@tcraxs tcraxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andersson007
Copy link
Contributor

thanks all!

D3DeFi pushed a commit to D3DeFi/ansible that referenced this pull request Dec 8, 2019
@atombrella @D3DeFi
Use context manager for mssql and postgresql modules. (ansible#65224)
45c470f
anshulbehl pushed a commit to anshulbehl/ansible that referenced this pull request Dec 10, 2019
@atombrella @anshulbehl
Use context manager for mssql and postgresql modules. (ansible#65224)
8a78c10
@ansible ansible locked and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tcraxs tcraxs tcraxs approved these changes

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. database Database category module This issue/PR relates to a module. postgresql PostgreSQL community shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atombrella @ansibot @sebasmannem @Andersson007 @tcraxs