syspatch: Check for apply=no condition

[Akasurde]

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lib/ansible/modules/system/syspatch.py

[ansibot]

cc @precurse
click here for bot help

[ansibot]

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/system/syspatch.py:129:5: E303: too many blank lines (2)

click here for bot help

[solvaholic]

Thank you @Akasurde , this does resolve the issue in #65216

A different issue is apparent now, though. On the remote host I reverted one patch:

my-host# syspatch -r
Reverting patch 008_mesa
my-host# syspatch -c
008_mesa

Then when I ran -m syspatch with apply=no, it applied the patch and didn't tell me:

my-host.example.com | CHANGED => {
    "ansible_facts": {
        "discovered_interpreter_python": "/usr/local/bin/python3.7"
    },
    "changed": true,
    "rc": 0,
    "reboot_needed": false,
    "stderr": "",
    "stderr_lines": [],
    "stdout": "",
    "stdout_lines": []
}

I reverted the patch on the remote host again. Then when I ran -m syspatch with apply=yes, it applied the patch and did tell me:

my-host.example.com | CHANGED => {
    "ansible_facts": {
        "discovered_interpreter_python": "/usr/local/bin/python3.7"
    },
    "changed": true,
    "rc": 0,
    "reboot_needed": false,
    "stderr": "",
    "stderr_lines": [],
    "stdout": "Installing patch 008_mesa\nErrata can be reviewed under /var/syspatch\n",
    "stdout_lines": [
        "Installing patch 008_mesa",
        "Errata can be reviewed under /var/syspatch"
    ]
}

I'll suggest a way to resolve this, tho I'm unfamiliar with how @precurse intends it to work.

[solvaholic]

Thank you for taking care of this @Akasurde

These each succeeded as expected with OpenBSD 6.6 and Python 3.7 at this PR's HEAD commit:

• apply=no
• apply=yes
• revert=one
• revert=all