Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_auto_logon - check, diff and store pass in LSA #65528

Merged
merged 4 commits into from Dec 5, 2019
Merged

win_auto_logon - check, diff and store pass in LSA #65528

merged 4 commits into from Dec 5, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

Added the following to win_auto_logon

  • Check mode support
  • Diff support
  • Will now store the password in LSA in an encrypted blob instead of plaintext in the registry
  • Added logon_count to control AutoLogonCount.
  • Expanded the tests a bit more
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

win_auto_logon

@jborean93 jborean93 mentioned this pull request Dec 5, 2019
Merged
@ansibot
Copy link
Contributor

ansibot commented Dec 5, 2019

cc @ShachafGoldstein @if-meaton @jhawkesworth @nitzmahone @prasoonkarunan
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Dec 5, 2019
@jborean93 jborean93 merged commit 4d3ebd6 into ansible:devel Dec 5, 2019
@jborean93 jborean93 deleted the win_auto_logon-lsa branch December 5, 2019 01:24
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Dec 5, 2019
anshulbehl pushed a commit to anshulbehl/ansible that referenced this pull request Dec 10, 2019
@jborean93 @anshulbehl
win_auto_logon - check, diff and store pass in LSA (ansible#65528)
74d60fc 
* win_auto_logon - check, diff and store pass in LSA

* Ensure baseline keys are set for test

* Skip remove item prop on check mode due to win bug

* Start at a cleared baseline to ensure old LSA secrets are cleared
@ansible ansible locked and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @ansibot @sivel