Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.9] Handle InternalError raised by cryptography when running in FIPS mode (#65477) #65668

Merged
merged 1 commit into from Jan 10, 2020
Merged

[stable-2.9] Handle InternalError raised by cryptography when running in FIPS mode (#65477) #65668

merged 1 commit into from Jan 10, 2020

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Dec 9, 2019

SUMMARY

Backport of #65477 for Ansible 2.9

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/compat/paramiko.py

@samdoran
[stable-2.9] Handle InternalError raised by cryptography when running…
5e255ea 
… in FIPS mode (ansible#65477)

Since older versions of paramiko do not require cryptography,
we cannot catch the exact exception from cryptography.

Remove other exceptions since we're catching everything now
(cherry picked from commit d35c1a4)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 9, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 17, 2019
@mattclay mattclay added the backport_verified This PR has been verified as a backport of a merged devel PR. label Jan 7, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 9, 2020
@mattclay mattclay merged commit e6db6d0 into ansible:stable-2.9 Jan 10, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jan 13, 2020
@ansible ansible locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport_verified This PR has been verified as a backport of a merged devel PR. backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samdoran @sivel @mattclay @ansibot