Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix purefa_host preferred array connection logic #65917

Merged
merged 1 commit into from Dec 17, 2019
Merged

Fix purefa_host preferred array connection logic #65917

merged 1 commit into from Dec 17, 2019

Conversation

sdodsley
Copy link
Contributor

@sdodsley sdodsley commented Dec 17, 2019 •
edited

SUMMARY

Ensure that the current array is an approved selection for preferred_array and also ensure that approved remote arrays are all syn-replication as async-replication is not supported for this option

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

purefa_host.py

@ansibot
Copy link
Contributor

ansibot commented Dec 17, 2019

cc @bannaych @dnix101 @genegr @lionmax @opslounge @raekins @sile16
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. pure_storage storage support:community This issue/PR relates to code supported by the Ansible community. labels Dec 17, 2019
rdeenik
rdeenik approved these changes Dec 17, 2019
View reviewed changes
Copy link

@rdeenik rdeenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Dec 17, 2019
@ansibot ansibot merged commit 4214420 into ansible:devel Dec 17, 2019
@sdodsley sdodsley deleted the fix_preffered_array_selection branch December 17, 2019 16:13
@ansible ansible locked and limited conversation to collaborators Jan 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rdeenik rdeenik rdeenik approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. pure_storage shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdodsley @ansibot @rdeenik