Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate log entries (and add item support for failures) #66098

Merged
merged 1 commit into from Feb 15, 2020
Merged

Fix duplicate log entries (and add item support for failures) #66098

merged 1 commit into from Feb 15, 2020

Conversation

akatch
Copy link
Contributor

@akatch akatch commented Dec 27, 2019

SUMMARY

Fixes #65561

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/callback/unixy.py

ADDITIONAL INFORMATION
### Before
yum...
  lime ok
  lime failed | msg: No package matching 'fakepkg' found available, installed or updated
  lime ok
  lime done
  lime done
  lime failed

### After
yum...
  lime ok
  lime failed | item: fakepkg | msg: No package matching 'fakepkg' found available, installed or updated                                                                                                 
  lime ok
  lime done | item: firefox
  lime done | item: mozilla-adblockplus
  lime failed

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Dec 27, 2019
@Akasurde Akasurde mentioned this pull request Dec 30, 2019
Closed
@ansibot ansibot added has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. community_review In order to be merged, this PR must follow the community review workflow. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 4, 2020
jamescassell
jamescassell approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jamescassell jamescassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@gundalow gundalow merged commit 936bd83 into ansible:devel Feb 15, 2020
@gundalow
Copy link
Contributor

Thanks for the fix.
Could you please raise a backport PR including changelog/fragment file so this can be fixed in the next Ansible 2.9 release? https://github.com/ansible/ansible/pull/66817/files

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 17, 2020
akatch added a commit to akatch/ansible that referenced this pull request Feb 25, 2020
@akatch
Fix duplicate log entries (and add item support for failures) (ansibl…
680fa6a 
…e#66098)

(cherry picked from commit 936bd83)
akatch pushed a commit to akatch/ansible that referenced this pull request Feb 25, 2020
Backport + changelog for ansible#66098
81d5c5f
@akatch akatch mentioned this pull request Feb 25, 2020
Merged
@akatch
Copy link
Contributor Author

akatch commented Feb 25, 2020 via email

mattclay pushed a commit that referenced this pull request Mar 3, 2020
@akatch
[Backport/2.9/66098]: Fix duplicate log entries (#67719)
c3dbd69 
* Fix duplicate log entries (and add item support for failures) (#66098)


(cherry picked from commit 936bd83)

* Backport + changelog for #66098
@ansible ansible locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamescassell jamescassell jamescassell approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. has_issue small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unixy callback duplicates entries in log
5 participants
@akatch @gundalow @jamescassell @sivel @ansibot