Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collection support for network platform agnostic modules #66342

Merged
merged 1 commit into from Jan 10, 2020
Merged

Add collection support for network platform agnostic modules #66342

merged 1 commit into from Jan 10, 2020

Conversation

ganeshrn
Copy link
Member

SUMMARY
  • Refactor net_base action plugin to invoke platform
    action plugin with implementation module name updated
    in the new task copy.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

net_base

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jan 10, 2020

cc @NilashishC @Qalthos @danielmellado @justjais @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jan 10, 2020
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 10, 2020
@ganeshrn
Add collection support for network platform agnostic modules
9d0a39f 
*  Refactor net_base action plugin to invoke platform
   action plugin with implementation module name updated
   in the new task copy.
@ansible ansible deleted a comment from ansibot Jan 10, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 10, 2020
@ansible-zuul
Copy link

ansible-zuul bot commented Jan 10, 2020

Build succeeded (third-party-check pipeline).

pabelanger
pabelanger approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@pabelanger pabelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will go along way to help for collections.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 10, 2020
@pabelanger pabelanger merged commit 0d85ab1 into ansible:devel Jan 10, 2020
ganeshrn added a commit to ganeshrn/ansible that referenced this pull request Jan 13, 2020
@ganeshrn
Add collection support for network platform agnostic modules (ansible…
d33bfb9 
…#66342)

*  Refactor net_base action plugin to invoke platform
   action plugin with implementation module name updated
   in the new task copy.

(cherry picked from commit 0d85ab1)
@ganeshrn ganeshrn mentioned this pull request Jan 13, 2020
Merged
NehaKembalkarA10 pushed a commit to NehaKembalkarA10/ansible that referenced this pull request Jan 30, 2020
@ganeshrn @NehaKembalkarA10
Add collection support for network platform agnostic modules (ansible…
ba6f3f7 
…#66342)

*  Refactor net_base action plugin to invoke platform
   action plugin with implementation module name updated
   in the new task copy.
@ansible ansible locked and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@pabelanger pabelanger pabelanger approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ganeshrn @ansibot @Qalthos @pabelanger