Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure --version works with non-ascii project path #66624

Merged
merged 1 commit into from May 29, 2020
Merged

Ensure --version works with non-ascii project path #66624

merged 1 commit into from May 29, 2020

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Jan 20, 2020 •
edited

SUMMARY

Fixes #66617

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/config/manager.py

@mkrizek mkrizek requested a review from sivel January 20, 2020 12:57
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 20, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 20, 2020
@samdoran
Copy link
Contributor

Please add an integration test for this, then we can merge it.

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jan 28, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 29, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 6, 2020
@mkrizek mkrizek changed the title Ensure --version works with non-ascii paths Ensure --version works with non-ascii project path Mar 26, 2020
@mkrizek
Copy link
Contributor Author

mkrizek commented Mar 26, 2020

Decided to turn this into a minimal fix for #66617.

@mkrizek mkrizek requested a review from sivel March 26, 2020 10:33
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 26, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 3, 2020
@ansibot ansibot added the collection Related to Ansible Collections work label Apr 29, 2020
@mkrizek mkrizek requested a review from samdoran May 20, 2020 16:42
@mkrizek mkrizek requested a review from bcoca May 26, 2020 14:51
@samdoran
Copy link
Contributor

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 29, 2020
@samdoran samdoran merged commit 3606dcf into ansible:devel May 29, 2020
@mkrizek mkrizek deleted the issue-66617 branch May 30, 2020 06:47
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jun 1, 2020
@mkrizek
Ensure --version works with non-ascii project path (ansible#66624)
e333f2b 
Fixes ansible#66617

(cherry picked from commit 3606dcf)
@mkrizek mkrizek mentioned this pull request Jun 1, 2020
Merged
nitzmahone pushed a commit that referenced this pull request Jun 17, 2020
@mkrizek
Ensure --version works with non-ascii project path (#66624) (#69789)
54d96ea 
Fixes #66617

(cherry picked from commit 3606dcf)
@ansible ansible locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

@sivel sivel Awaiting requested review from sivel

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. collection Related to Ansible Collections work shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible does not work when the working directory contains some non-ASCII characters
4 participants
@mkrizek @samdoran @sivel @ansibot