git: get_head_branch incorrect when branch name contains a slash

[thpani]

Issue Type:

Bug Report

Ansible Version:

1.5.3

Environment:

OS X 10.9.2

Summary:

get_head_branch() fails to correctly compute the HEAD branch if the branch name contains a slash. This is caused by splitting on '/' and indexing [-1] on https://github.com/ansible/ansible/blob/devel/library/source_control/git#L350

Steps To Reproduce:

Run from this playbook:

- name: checkout llvm
  git: repo=https://github.com/thpani/llvm.git
       dest=/home/vagrant/llvm/

Checkout fails because branch is computed as "release_33_nullsucc" instead of "patches/release_33_nullsucc".

Expected Results:

get_head_branch() computes the correct branch.

I.e. behave as if the above example were

- name: checkout llvm
  git: repo=https://github.com/thpani/llvm.git
       dest=/home/vagrant/llvm/
       version=patches/release_33_nullsucc

Actual Results:

TASK: [checkout llvm] *********************************************************
failed: [default] => {"failed": true}
msg: Failed to checkout branch release_33_nullsucc

[mpdehaan]

Hi!

Thanks very much for your interest in Ansible. It sincerely means a lot to us.

On September 26, 2014, due to enormous levels of contribution to the project Ansible decided to reorganize module repos, making it easier
for developers to work on the project and for us to more easily manage new contributions and tickets.

We split modules from the main project off into two repos, http://github.com/ansible/ansible-modules-core and http://github.com/ansible/ansible-modules-extras

If you would still like this ticket attended to, and believe this problem or idea is still present in the latest version of Ansible (1.7.2) or the development branch, we will need your help in having it reopened in one of the two new repos, and instructions are provided below.

We apologize that we are not able to make this transition happen seamlessly, though this is a one-time change and your help is greatly appreciated --
this will greatly improve velocity going forward.

Both sets of modules will ship with Ansible, though they'll receive slightly different ticket handling.

To locate where a module lives between 'core' and 'extras'

• Find the module at http://docs.ansible.com/list_of_all_modules.html
• Open the documentation page for that module
• If the bottom of the docs say "This is an extras module", submit your ticket to https://github.com/ansible/ansible-modules-extras
• Otherwise, submit your pull request to update the existing module to https://github.com/ansible/ansible-modules-core
• action_plugins (modules with server side components) still live in the main repo. If your ticket affects both, open the ticket
  on the module repo just the same.

Additionally, should you need more help with this, you can ask questions on:

• the ansible-project mailing list: https://groups.google.com/forum/#!forum/ansible-project

Thank you very much!