Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

galaxy: fix AttributeError on empty requirements.yml #66726

Merged
merged 2 commits into from Jan 23, 2020
Merged

galaxy: fix AttributeError on empty requirements.yml #66726

merged 2 commits into from Jan 23, 2020

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Jan 23, 2020

SUMMARY

Fixes #66725
Simple kind of typo fix causes an AttributeError

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

galaxy

ADDITIONAL INFORMATION

after fix

 $ ansible-galaxy install -r requirements.yml -v  
Using /home/rmoser/Projects/puzzle/ansible-puzzle/ansible.cfg as config file
ERROR! No requirements found in file 'requirements.yml'

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 23, 2020
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed small_patch labels Jan 23, 2020
@jborean93
Copy link
Contributor

Thanks for the quick fix

@jborean93 jborean93 merged commit 9e8fb5b into ansible:devel Jan 23, 2020
@resmo resmo deleted the fix/ansible-galaxy-emtpy-requirements.yml-exception branch January 23, 2020 20:31
@resmo resmo mentioned this pull request Jan 24, 2020
Merged
@resmo
Copy link
Contributor Author

resmo commented Jan 24, 2020

backport to 2.9 #66752

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jan 24, 2020
nitzmahone pushed a commit that referenced this pull request Feb 10, 2020
@resmo
galaxy: fix AttributeError on empty requirements.yml (#66726) (#66752)
77985f2 
* galaxy: fix AttributeError on empty requirements.yml

* add changelog

(cherry picked from commit 9e8fb5b)
@ansible ansible locked and limited conversation to collaborators Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible galaxy install exception on empty requirements.yml
4 participants
@resmo @jborean93 @sivel @ansibot