Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added -LogPath param from Install-ADDSForest to win_domain module #66956

Merged
merged 3 commits into from Feb 4, 2020
Merged

Added -LogPath param from Install-ADDSForest to win_domain module #66956

merged 3 commits into from Feb 4, 2020

Conversation

AirCombat
Copy link
Contributor

SUMMARY

Logpath is currently omitted from the win_domain module despite being a valid parameter in powershell. We cannot use this module currently due to this issue.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_domain

ADDITIONAL INFORMATION

Install-ADDSForest: https://docs.microsoft.com/en-us/powershell/module/addsdeployment/install-addsforest?view=win10-ps

@AirCombat
Added omitted logpath parameter to win_domain
24c9707 
The Install-ADDSForest -LogPath param seems to have been omitted in the win_domain module. We do not use this module organisation-wide as its non trivial to change the log patch once AD is set up. I will also update docs
@AirCombat
Removed trailing whitespace
cec4bda
@AirCombat
Added logpath option to win_domain module docs
46013e1
@ansibot
Copy link
Contributor

ansibot commented Jan 30, 2020

cc @ShachafGoldstein @if-meaton @jborean93 @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Jan 30, 2020
@AirCombat AirCombat changed the title Added -LopPath param from Install-ADDSForest to win_domain module Added -LogPath param from Install-ADDSForest to win_domain module Jan 30, 2020
@AirCombat AirCombat mentioned this pull request Jan 30, 2020
Closed
@jborean93 jborean93 merged commit 81378b3 into ansible:devel Feb 4, 2020
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Feb 4, 2020
@jborean93 jborean93 mentioned this pull request Feb 5, 2020
Closed
@jborean93 jborean93 mentioned this pull request Feb 16, 2020
Closed
@ansible ansible locked and limited conversation to collaborators Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AirCombat @ansibot @jborean93 @s-hertel