New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible-test - add constraint for virtualenv #67289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.10
This issue/PR affects Ansible v2.10
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
has_issue
needs_triage
Needs a first human triage before being processed.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
labels
Feb 10, 2020
mattclay
removed
the
needs_triage
Needs a first human triage before being processed.
label
Feb 10, 2020
mattclay
approved these changes
Feb 10, 2020
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Feb 10, 2020
mattclay
reviewed
Feb 10, 2020
samdoran
force-pushed
the
ci/virtualenv-constraint
branch
from
February 10, 2020 22:28
a62a77e
to
4160790
Compare
mattclay
approved these changes
Feb 10, 2020
webknjaz
approved these changes
Feb 10, 2020
It turns out the issue wasn't with the constraints for tests, but the virtualenv installation on macOS during setup of the remote host. |
mattclay
pushed a commit
to mattclay/ansible
that referenced
this pull request
Feb 11, 2020
) * ansible-test - add constraint for virtualenv * Limit virtualenv only on macOS. Co-authored-by: Matt Clay <matt@mystile.com> (cherry picked from commit 8f296a6) Co-authored-by: Sam Doran <sdoran@redhat.com>
This was referenced Feb 11, 2020
mattclay
pushed a commit
to mattclay/ansible
that referenced
this pull request
Feb 11, 2020
) * ansible-test - add constraint for virtualenv * Limit virtualenv only on macOS. Co-authored-by: Matt Clay <matt@mystile.com> (cherry picked from commit 8f296a6) Co-authored-by: Sam Doran <sdoran@redhat.com>
mattclay
pushed a commit
to mattclay/ansible
that referenced
this pull request
Feb 11, 2020
) * ansible-test - add constraint for virtualenv * Limit virtualenv only on macOS. Co-authored-by: Matt Clay <matt@mystile.com>. (cherry picked from commit 8f296a6) Co-authored-by: Sam Doran <sdoran@redhat.com>
mattclay
pushed a commit
that referenced
this pull request
Feb 11, 2020
* ansible-test - add constraint for virtualenv * Limit virtualenv only on macOS. Co-authored-by: Matt Clay <matt@mystile.com>. (cherry picked from commit 8f296a6) Co-authored-by: Sam Doran <sdoran@redhat.com>
mattclay
pushed a commit
that referenced
this pull request
Feb 11, 2020
* ansible-test - add constraint for virtualenv * Limit virtualenv only on macOS. Co-authored-by: Matt Clay <matt@mystile.com> (cherry picked from commit 8f296a6) Co-authored-by: Sam Doran <sdoran@redhat.com>
mattclay
pushed a commit
that referenced
this pull request
Feb 11, 2020
* ansible-test - add constraint for virtualenv * Limit virtualenv only on macOS. Co-authored-by: Matt Clay <matt@mystile.com> (cherry picked from commit 8f296a6) Co-authored-by: Sam Doran <sdoran@redhat.com>
href
pushed a commit
to cloudscale-ch/ansible
that referenced
this pull request
Feb 12, 2020
* ansible-test - add constraint for virtualenv * Limit virtualenv only on macOS. Co-authored-by: Matt Clay <matt@mystile.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.10
This issue/PR affects Ansible v2.10
bug
This issue/PR relates to a bug.
has_issue
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The new version of
virtualenv
has a dependency onzipp
, which does not get installed by the older version ofpip
on our macOS image in CI.ISSUE TYPE
COMPONENT NAME
test/lib/ansible_test/_data/requirements/constraints.txt