Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-test - add constraint for virtualenv #67289

Merged
merged 2 commits into from Feb 11, 2020

Conversation

samdoran
Copy link
Contributor

SUMMARY

The new version of virtualenv has a dependency on zipp, which does not get installed by the older version of pip on our macOS image in CI.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/lib/ansible_test/_data/requirements/constraints.txt

@ansibot
Copy link
Contributor

ansibot commented Feb 10, 2020

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Feb 10, 2020
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Feb 10, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 10, 2020
@mattclay
Copy link
Member

It turns out the issue wasn't with the constraints for tests, but the virtualenv installation on macOS during setup of the remote host.

@mattclay mattclay merged commit 8f296a6 into ansible:devel Feb 11, 2020
mattclay pushed a commit to mattclay/ansible that referenced this pull request Feb 11, 2020
)

* ansible-test - add constraint for virtualenv

* Limit virtualenv only on macOS.

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit 8f296a6)

Co-authored-by: Sam Doran <sdoran@redhat.com>
mattclay pushed a commit to mattclay/ansible that referenced this pull request Feb 11, 2020
)

* ansible-test - add constraint for virtualenv

* Limit virtualenv only on macOS.

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit 8f296a6)

Co-authored-by: Sam Doran <sdoran@redhat.com>
mattclay pushed a commit to mattclay/ansible that referenced this pull request Feb 11, 2020
)

* ansible-test - add constraint for virtualenv

* Limit virtualenv only on macOS.

Co-authored-by: Matt Clay <matt@mystile.com>.
(cherry picked from commit 8f296a6)

Co-authored-by: Sam Doran <sdoran@redhat.com>
mattclay pushed a commit that referenced this pull request Feb 11, 2020
* ansible-test - add constraint for virtualenv

* Limit virtualenv only on macOS.

Co-authored-by: Matt Clay <matt@mystile.com>.
(cherry picked from commit 8f296a6)

Co-authored-by: Sam Doran <sdoran@redhat.com>
mattclay pushed a commit that referenced this pull request Feb 11, 2020
* ansible-test - add constraint for virtualenv

* Limit virtualenv only on macOS.

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit 8f296a6)

Co-authored-by: Sam Doran <sdoran@redhat.com>
mattclay pushed a commit that referenced this pull request Feb 11, 2020
* ansible-test - add constraint for virtualenv

* Limit virtualenv only on macOS.

Co-authored-by: Matt Clay <matt@mystile.com>
(cherry picked from commit 8f296a6)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@samdoran samdoran deleted the ci/virtualenv-constraint branch February 11, 2020 14:48
href pushed a commit to cloudscale-ch/ansible that referenced this pull request Feb 12, 2020
* ansible-test - add constraint for virtualenv

* Limit virtualenv only on macOS.

Co-authored-by: Matt Clay <matt@mystile.com>
@ansible ansible locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants