Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_login: fix permissions for ~/.docker/config.json #67353

Merged
merged 2 commits into from Feb 15, 2020
Merged

docker_login: fix permissions for ~/.docker/config.json #67353

merged 2 commits into from Feb 15, 2020

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fixes #67347.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_login

@felixfontein felixfontein changed the title [WIP] docker_login: fix permissions for ~/.docker/config.json docker_login: fix permissions for ~/.docker/config.json Feb 12, 2020
@ansibot
Copy link
Contributor

ansibot commented Feb 12, 2020

cc @DBendit @WojciechowskiPiotr @akshay196 @chouseknecht @danihodovic @dariko @jwitko @kassiansun @olsaki @tbouvet
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Feb 12, 2020
@felixfontein
Copy link
Contributor Author

ready_for_review

@felixfontein felixfontein mentioned this pull request Feb 12, 2020
Closed
gundalow
gundalow reviewed Feb 15, 2020
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay for tests!

@gundalow gundalow merged commit 55cb8c5 into ansible:devel Feb 15, 2020
@felixfontein felixfontein deleted the docker_login-fix-permissions branch February 15, 2020 19:25
@felixfontein
Copy link
Contributor Author

@gundalow thanks a lot for reviewing and merging!

felixfontein added a commit to felixfontein/ansible that referenced this pull request Feb 15, 2020
@felixfontein
docker_login: fix permissions for ~/.docker/config.json (ansible#67353)
2244e5c 
* Fix permissions for ~/.docker/config.json.

* Add changelog, remove debug output.

(cherry picked from commit 55cb8c5)
@felixfontein felixfontein mentioned this pull request Feb 15, 2020
Merged
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 17, 2020
mattclay pushed a commit that referenced this pull request Mar 2, 2020
@felixfontein @mattclay
docker_login: fix permissions for ~/.docker/config.json (#67353)
a24dcf2 
* Fix permissions for ~/.docker/config.json.

* Add changelog, remove debug output.

(cherry picked from commit 55cb8c5)
@ansible ansible locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker_login not create config.json file with correct permission
4 participants
@felixfontein @ansibot @gundalow @sivel