Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let meta tasks use tags #67508

Merged
merged 3 commits into from Aug 21, 2020
Merged

let meta tasks use tags #67508

merged 3 commits into from Aug 21, 2020

Conversation

s-hertel
Copy link
Contributor

SUMMARY

Fixes #64558

ISSUE TYPE
  • Bugfix Pull Request

@s-hertel s-hertel changed the title let meta tasks to use tags let meta tasks use tags Feb 18, 2020
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 18, 2020
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 18, 2020
@samdoran samdoran requested a review from bcoca February 25, 2020 15:44
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Feb 25, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 4, 2020
@mkrizek mkrizek mentioned this pull request Apr 3, 2020
Closed
@mkrizek mkrizek mentioned this pull request Apr 14, 2020
Closed
@jimi-c jimi-c self-requested a review May 29, 2020 17:06
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 14, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 24, 2020
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 3, 2020
@s-hertel
Support tags for explicit meta tasks
38315d5 
Add --list-tasks tests for meta tags

changelog

ci_complete
@s-hertel
Copy link
Contributor Author

Rebased to use the common code from #71009

@s-hertel s-hertel requested a review from relrod August 19, 2020 19:48
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 19, 2020
relrod
relrod reviewed Aug 19, 2020
View reviewed changes
lib/ansible/cli/playbook.py Outdated Show resolved Hide resolved
changelogs/fragments/67508-meta-task-tags.yaml Outdated Show resolved Hide resolved
s-hertel
s-hertel commented Aug 19, 2020
View reviewed changes
lib/ansible/cli/playbook.py Outdated Show resolved Hide resolved
@ansibot ansibot added the docs This issue/PR relates to or includes documentation. label Aug 20, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 20, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 20, 2020
samccann
samccann approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs portion LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 20, 2020
@s-hertel s-hertel merged commit 1425e35 into ansible:devel Aug 21, 2020
@s-hertel
Copy link
Contributor Author

Thanks for the reviews!

@bmillemathias bmillemathias mentioned this pull request Aug 21, 2020
Closed
@ansible ansible locked and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jimi-c jimi-c jimi-c approved these changes

@relrod relrod relrod approved these changes

@mkrizek mkrizek mkrizek approved these changes

@samccann samccann samccann approved these changes

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. has_issue module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. utilities Utilities category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tags doesn't work properly with module meta
7 participants
@s-hertel @ansibot @samccann @jimi-c @relrod @mkrizek @samdoran