Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To make work Cisco ASA facts work as expected #68076

Merged
merged 1 commit into from
Apr 6, 2020
Merged

To make work Cisco ASA facts work as expected #68076

merged 1 commit into from
Apr 6, 2020

Conversation

justjais
Copy link
Contributor

@justjais justjais commented Mar 6, 2020

SUMMARY

To make work Cisco ASA facts work as expected, respective asa facts PR opened in it's respective collections: ansible-collections/cisco.asa#6

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/config/base.yml

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 6, 2020
@bcoca bcoca requested a review from trishnaguha March 10, 2020 15:07
@bcoca bcoca added networking Network category and removed needs_triage Needs a first human triage before being processed. labels Mar 10, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 16, 2020
@justjais justjais merged commit f921b1e into ansible:devel Apr 6, 2020
@ansible ansible locked and limited conversation to collaborators May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. networking Network category small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justjais @trishnaguha @bcoca @ansibot