Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hacking/shippable/incidental.py script. #68182

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

mattclay
Copy link
Member

SUMMARY

Add hacking/shippable/incidental.py script and README.md to hacking/shippable/ directory.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

hacking/shippable/incidental.py

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 12, 2020
Copy link
Contributor

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ran things locally and can easily see what incidental coverage is occurring with the Windows modules.

Reducing incidental test coverage, and eventually removing incidental tests involves the following process:

1. Run the entire test suite with code coverage enabled.
This is done automatically each day on Shippable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an easy way for someone to determine the run number for this nightly run?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can look at the run history for a given branch and look for the most recent run triggered by the shipabull user. Here's the link for devel:

https://app.shippable.com/github/ansible/ansible/runs?branchName=devel

Until development resumes on devel you'll want to look at temp-2.10-devel instead:

https://app.shippable.com/github/ansible/ansible/runs?branchName=temp-2.10-devel

However, it's likely that the run has failed results, so you'll need to re-run the failed jobs. However, those will show up as triggered by the user who restarted them, which means multiple people trying to go through this process on the same day may each end up re-running the failed jobs.

Unfortunately there's not an easy way to deal with this currently. It should be possible to create a script using the Shippable API to find the latest nightly run, taking into account re-runs, so you'll know which one to use.

@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Mar 12, 2020
@mattclay mattclay merged commit abc7402 into ansible:temp-2.10-devel Mar 12, 2020
@mattclay mattclay deleted the at-coverage-analysis branch March 12, 2020 01:23
sivel pushed a commit that referenced this pull request Mar 23, 2020
* Add hacking/shippable/incidental.py script.

* Add README.md.
@ansible ansible locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants