Prevent rewriting nested Block's data in filter_tagged_tasks #68337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.10
ansibot
added
core_review
ansibot
added
the
stale_ci
bcoca
removed
the
needs_triage
This patch fixes the issue where nested Block copies were created from incorrect Block object. This resulted in nested Blocks data like ``name`` or ``_uuid`` to contain values from the Block the filter_tagged_tasks method was called on. ci_complete
jimi-c
approved these changes
Apr 20, 2020
bcoca
pushed a commit
to bcoca/ansible
that referenced
this pull request
Apr 22, 2020
…#68337) This patch fixes the issue where nested Block copies were created from incorrect Block object. This resulted in nested Blocks data like ``name`` or ``_uuid`` to contain values from the Block the filter_tagged_tasks method was called on.
bcoca
pushed a commit
to bcoca/ansible
that referenced
this pull request
Apr 28, 2020
…#68337) This patch fixes the issue where nested Block copies were created from incorrect Block object. This resulted in nested Blocks data like ``name`` or ``_uuid`` to contain values from the Block the filter_tagged_tasks method was called on.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This patch fixes the issue where nested Block copies were created from
incorrect Block object. This resulted in nested Blocks data like
nameor
_uuidto contain values from the Block the filter_tagged_tasksmethod was called on.
ci_complete
ISSUE TYPE
COMPONENT NAME
lib/ansible/playbook/block.py