Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage for lookup_config #68566

Merged
merged 2 commits into from Mar 31, 2020
Merged

Conversation

relrod
Copy link
Member

@relrod relrod commented Mar 30, 2020

SUMMARY

Test all the things!

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/integration/targets/lookup_config

Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 30, 2020
@relrod relrod requested a review from mattclay March 30, 2020 21:07
lookup3: '{{lookup("config", "THIS_DOES_NOT_EXIST", on_missing="skip")}}'
register: lookup_config_3

# TODO: Is there a decent way to check that the warning is actually triggered?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently any tests that need to consult warnings do so by running as a script-based test, saving the playbook output and then searching it for the desired output.

@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Mar 31, 2020
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod relrod merged commit 541384e into ansible:devel Mar 31, 2020
@ansible ansible locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants