Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebRequest - Fix use_proxy: no on module options #68603

Merged
merged 2 commits into from Apr 1, 2020
Merged

WebRequest - Fix use_proxy: no on module options #68603

merged 2 commits into from Apr 1, 2020

Conversation

jborean93
Copy link
Contributor

SUMMARY

When use_proxy: no was set we never overwrote the actual WebRequest object with the $null proxy value which meant the default proxy was being used. This PR makes sure we always set the proxy based on the module options.

Fixes #68528

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Ansible.ModuleUtils.WebRequest

@jborean93 jborean93 mentioned this pull request Apr 1, 2020
Closed
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Apr 1, 2020
@jborean93 jborean93 merged commit ae1cd27 into ansible:devel Apr 1, 2020
@jborean93 jborean93 deleted the win_webrequest-no_proxy branch April 1, 2020 21:18
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 1, 2020
@jborean93
WebRequest - Fix use_proxy: no on module options (ansible#68603)
6258d66 
* WebRequest - Fix use_proxy: no on module options

* Fix up changelog fragment

(cherry picked from commit ae1cd27)
@jborean93 jborean93 mentioned this pull request Apr 1, 2020
Merged
@jborean93
Copy link
Contributor Author

Backport PR to stable-2.9 #68626.

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 2, 2020
mattclay pushed a commit that referenced this pull request Apr 15, 2020
@jborean93 @mattclay
WebRequest - Fix use_proxy: no on module options (#68603)
cef6296 
* WebRequest - Fix use_proxy: no on module options

* Fix up changelog fragment

(cherry picked from commit ae1cd27)
@ansible ansible locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible.ModuleUtils.WebRequest: cannot ignore proxy
3 participants
@jborean93 @mkrizek @ansibot