Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev guide: add notes about different image types for integration and unit/sanity tests #68663

Merged
merged 4 commits into from
Apr 7, 2020
Merged

Dev guide: add notes about different image types for integration and unit/sanity tests #68663

merged 4 commits into from
Apr 7, 2020

Conversation

Andersson007
Copy link
Contributor

SUMMARY

Dev guide: add notes about different image types for integration and unit/sanity tests.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/dev_guide/testing_integration.rst
docs/docsite/rst/dev_guide/testing_sanity.rst
docs/docsite/rst/dev_guide/testing_units.rst

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 3, 2020
@felixfontein
Copy link
Contributor

CC @mattclay

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 3, 2020
tremble
tremble approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 6, 2020
acozine
acozine reviewed Apr 6, 2020
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Andersson007 if you'll accept Matt Clay's revision, I'm happy to merge this.

@Andersson007 @mattclay
Update docs/docsite/rst/dev_guide/testing_integration.rst
d199ec1 
Co-Authored-By: Matt Clay <matt@mystile.com>
@Andersson007
Copy link
Contributor Author

@acozine accepted:)

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 7, 2020
@acozine
Copy link
Contributor

acozine commented Apr 7, 2020

Thanks @Andersson007!

@acozine acozine merged commit 598ead9 into ansible:devel Apr 7, 2020
@ansible ansible locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

@tremble tremble tremble approved these changes

@mattclay mattclay mattclay approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Andersson007 @felixfontein @acozine @tremble @mattclay @ansibot