Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[copy] Add some test coverage for check_mode #68895

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

relrod
Copy link
Member

@relrod relrod commented Apr 12, 2020

SUMMARY

Change:
Adds some missing coverage for the copy module when check_mode: True.

Test Plan:
Ran test with --coverage and looked at the resulting report.

Signed-off-by: Rick Elrod rick@elrod.me

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/integration/targets/copy

@relrod relrod requested a review from mattclay April 12, 2020 09:25
Change:
Adds some missing coverage for the copy module when `check_mode: True`.

Test Plan:
Ran test with --coverage and looked at the resulting report.

Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. files Files category needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 12, 2020
@relrod
Copy link
Member Author

relrod commented Apr 12, 2020

Pulling these tests in from #68233.

@relrod relrod merged commit 648b3d4 into ansible:devel Apr 17, 2020
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Apr 17, 2020
bcoca pushed a commit to bcoca/ansible that referenced this pull request Apr 22, 2020
Change:
Adds some missing coverage for the copy module when `check_mode: True`.

Test Plan:
Ran test with --coverage and looked at the resulting report.

Signed-off-by: Rick Elrod <rick@elrod.me>
bcoca pushed a commit to bcoca/ansible that referenced this pull request Apr 28, 2020
Change:
Adds some missing coverage for the copy module when `check_mode: True`.

Test Plan:
Ran test with --coverage and looked at the resulting report.

Signed-off-by: Rick Elrod <rick@elrod.me>
@ansible ansible locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. files Files category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants