include_role: Strictly check string datatype for *_from #68958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.10
|
The test |
ansibot
added
needs_revision
Strictly check string datatype for 'tasks_from', 'vars_from', 'defaults_from', and 'handlers_from' in include_role Fixes: ansible#68515 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
sivel
reviewed
Apr 15, 2020
| args_value = ir.args.get(key) | ||
| if not isinstance(args_value, string_types): | ||
| raise AnsibleParserError('Expected a string for %s but got %s instead' % (key, type(args_value))) | ||
| ir._from_files[from_key] = basename(args_value) |
There was a problem hiding this comment.
I think this is acceptable for now, but for the future, I think we should see if we can make use of post validating to cover all arguments in a single standard way.
sivel
approved these changes
Apr 15, 2020
ansibot
added
has_issue
core_review
mkrizek
removed
the
needs_triage
bcoca
pushed a commit
to bcoca/ansible
that referenced
this pull request
Apr 22, 2020
Strictly check string datatype for 'tasks_from', 'vars_from', 'defaults_from', and 'handlers_from' in include_role Fixes: ansible#68515 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
bcoca
pushed a commit
to bcoca/ansible
that referenced
this pull request
Apr 28, 2020
Strictly check string datatype for 'tasks_from', 'vars_from', 'defaults_from', and 'handlers_from' in include_role Fixes: ansible#68515 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Strictly check string datatype for 'tasks_from', 'vars_from',
'defaults_from', and 'handlers_from' in include_role
Fixes: #68515
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/68515_include_role_vars_from.yml
lib/ansible/playbook/role_include.py
test/integration/targets/include_import/role/test_include_role.yml
test/integration/targets/include_import/role/test_include_role_vars_from.yml
test/integration/targets/include_import/runme.sh