Enable service integration tests for FreeBSD #68980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change: Adds necessary rc file for freebsd, and gets tests passing for it. Test Plan: Ran test with `--remote freebsd/12.1` and `--remote freebsd/11.1`. Both passed. Signed-off-by: Rick Elrod <rick@elrod.me>
ansibot
added
affects_2.10
mattclay
requested changes
Apr 17, 2020
mattclay
removed
the
needs_triage
Co-Authored-By: Matt Clay <matt@mystile.com>
Signed-off-by: Rick Elrod <rick@elrod.me>
mattclay
approved these changes
Apr 17, 2020
bcoca
pushed a commit
to bcoca/ansible
that referenced
this pull request
Apr 22, 2020
* Enable service integration tests for FreeBSD Change: Adds necessary rc file for freebsd, and gets tests passing for it. Test Plan: Ran test with `--remote freebsd/12.1` and `--remote freebsd/11.1`. Both passed. Signed-off-by: Rick Elrod <rick@elrod.me> * Update test/integration/targets/service/tasks/rc_setup.yml Co-Authored-By: Matt Clay <matt@mystile.com> * fix up comment Signed-off-by: Rick Elrod <rick@elrod.me> Co-authored-by: Matt Clay <matt@mystile.com>
bcoca
pushed a commit
to bcoca/ansible
that referenced
this pull request
Apr 28, 2020
* Enable service integration tests for FreeBSD Change: Adds necessary rc file for freebsd, and gets tests passing for it. Test Plan: Ran test with `--remote freebsd/12.1` and `--remote freebsd/11.1`. Both passed. Signed-off-by: Rick Elrod <rick@elrod.me> * Update test/integration/targets/service/tasks/rc_setup.yml Co-Authored-By: Matt Clay <matt@mystile.com> * fix up comment Signed-off-by: Rick Elrod <rick@elrod.me> Co-authored-by: Matt Clay <matt@mystile.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Change:
Adds necessary rc file for freebsd, and gets tests passing for it.
Test Plan:
Ran test with
--remote freebsd/12.1and--remote freebsd/11.1. Bothpassed.
(This also knocks out an incidental arc.)
Signed-off-by: Rick Elrod rick@elrod.me
ISSUE TYPE
COMPONENT NAME
service tests