Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pass file mode during recursive copy on symlink files. #69011

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Do not pass file mode during recursive copy on symlink files. #69011

merged 2 commits into from
Apr 30, 2020

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Apr 17, 2020

SUMMARY

The 'file' module cannot deal with mode=preserve. Do not pass that
mode to the module when 'preserve' is used.

Fixes #68471

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/action/copy.py

ADDITIONAL INFORMATION

See #68471 for reproducer.

@Shrews
Do not pass file mode during recursive copy on symlink files.
503447e 
The 'file' module cannot deal with mode=preserve. Do not pass that
mode to the module when 'preserve' is used.
@Shrews
Fix changelog fragment filename
0a95a49
@Shrews
Copy link
Contributor Author

Shrews commented Apr 20, 2020

/rebuild_failed

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. files Files category needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 24, 2020
@jimi-c jimi-c merged commit 1142faa into ansible:devel Apr 30, 2020
@Shrews Shrews deleted the 68471-bug-fix branch April 30, 2020 20:01
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label May 4, 2020
@ansible ansible locked and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. files Files category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursive "copy" module "mode=preserve" fails on symlinks
4 participants
@Shrews @jimi-c @mkrizek @ansibot