Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing parameter #69160

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Added missing parameter #69160

merged 2 commits into from
Apr 28, 2020

Conversation

ChrisAHolland
Copy link
Contributor

SUMMARY

The call to daemonize() in sysvinit.py was missing the module parameter included in the function definition in service.py.

This pull request simply adds that parameter, as module is used for error handling in daemonize().

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sysvinit.py

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category labels Apr 24, 2020
@ChrisAHolland
Copy link
Contributor Author

CC @mattclay @bcoca

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 27, 2020
@ChrisAHolland
Copy link
Contributor Author

@mattclay Thanks!

@Akasurde Akasurde merged commit 339c442 into ansible:devel Apr 28, 2020
@Akasurde
Copy link
Member

@ChrisAHolland Thanks for the contribution. @mattclay Thanks for the review.

@Akasurde
Copy link
Member

Backport 2.9 - #69212

bcoca pushed a commit to bcoca/ansible that referenced this pull request Apr 28, 2020
@ChrisAHolland @bcoca
Added missing parameter (ansible#69160)
dbc275f 
The call to daemonize() in sysvinit.py was missing the module parameter included in the function definition in service.py.

This pull request simply adds that parameter, as the module is used for error handling in daemonize().
@ChrisAHolland ChrisAHolland deleted the add-missing-parameter branch April 28, 2020 18:51
@Akasurde Akasurde mentioned this pull request May 5, 2020
Merged
@ansible ansible locked and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChrisAHolland @Akasurde @mattclay @ansibot