Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed redundant conditional in paramiko_ssh.py #69164

Merged
merged 3 commits into from Apr 28, 2020
Merged

Removed redundant conditional in paramiko_ssh.py #69164

merged 3 commits into from Apr 28, 2020

Conversation

ChrisAHolland
Copy link
Contributor

@ChrisAHolland ChrisAHolland commented Apr 25, 2020 •
edited

SUMMARY

paramiko_ssh.py contained an if statement that always evaluated to True in the _parse_proxy_command() method.

This PR removes that redundant check.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

paramiko_ssh

ADDITIONAL INFORMATION

I believe this conditional was originally created because it was believes that a list containing ['','',''] would be considered None.

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 25, 2020
@ChrisAHolland
Copy link
Contributor Author

CC @mattclay @bcoca

@ChrisAHolland
Copy link
Contributor Author

@mattclay Thanks!

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 28, 2020
@bcoca bcoca merged commit d42151e into ansible:devel Apr 28, 2020
bcoca pushed a commit to bcoca/ansible that referenced this pull request Apr 28, 2020
@ChrisAHolland @bcoca
Removed redundant conditional in paramiko_ssh.py (ansible#69164)
2c60a6a 
* Removed redundant conditional

* Added changelog fragment

* Removed trailing whitespace
@ChrisAHolland ChrisAHolland deleted the remove_redundant_conditional branch April 28, 2020 18:51
@ansible ansible locked and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChrisAHolland @mattclay @bcoca @ansibot