Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

galaxy: Handle empty roles and collections #69199

Merged
merged 1 commit into from
May 5, 2020
Merged

galaxy: Handle empty roles and collections #69199

merged 1 commit into from
May 5, 2020

Conversation

Akasurde
Copy link
Member

SUMMARY

Galaxy collection install command raised indexError,
when requirements.yml contains empty roles and collections.

This fix handles empty roles and/or empty collections.

Fixes: #68186

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/68186_collection_index_err.yml
lib/ansible/cli/galaxy.py
test/integration/targets/ansible-galaxy-collection/tasks/download.yml

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 27, 2020
@Akasurde Akasurde mentioned this pull request Apr 28, 2020
Closed
@Akasurde
galaxy: Handle empty roles and collections
b0b2892 
Galaxy collection install command raised indexError,
when requirements.yml contains empty roles and collections.

This fix handles empty roles and/or empty collections.

Fixes: ansible#68186

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@resmo
Copy link
Contributor

resmo commented Apr 28, 2020

/rebuild_failed

@jimi-c jimi-c merged commit 8d43d79 into ansible:devel May 5, 2020
@jimi-c
Copy link
Member

jimi-c commented May 5, 2020

Thanks!

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label May 5, 2020
@ansible ansible locked and limited conversation to collaborators Jun 2, 2020
@Akasurde Akasurde deleted the i68186 branch July 13, 2021 04:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo left review comments

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Galaxy install command does not validate null collections entry
6 participants
@Akasurde @resmo @jimi-c @jborean93 @bcoca @ansibot