Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Small grammar improvement in the community guide #69304

Merged
merged 1 commit into from
May 4, 2020
Merged

docs: Small grammar improvement in the community guide #69304

merged 1 commit into from
May 4, 2020

Conversation

jdufresne
Copy link
Contributor

SUMMARY

The comma should not be included as it is not joining two independent
clauses.

ISSUE TYPE
  • Docs Pull Request

@jdufresne
docs: Small grammar improvement in the community guide
9743214 
The comma should not be included as it is not joining two independent
clauses.
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 4, 2020
@acozine
Copy link
Contributor

acozine commented May 4, 2020

Nice catch @jdufresne, thanks for the PR. Because we are still working on the pipeline for module docs in the new collections ecosystem, we've frozen publication of the docs from the devel branch. So you won't see this change on the website quite yet. But it will be there in the code!

@acozine acozine removed the needs_triage Needs a first human triage before being processed. label May 4, 2020
@acozine acozine merged commit eab4f9a into ansible:devel May 4, 2020
@ansible ansible locked and limited conversation to collaborators Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdufresne @acozine @ansibot