Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware: example should use FQCN #69351

Merged
merged 3 commits into from
May 11, 2020
Merged

vmware: example should use FQCN #69351

merged 3 commits into from
May 11, 2020

Conversation

goneri
Copy link
Contributor

@goneri goneri commented May 6, 2020

SUMMARY

For instance, you should use community.vmware.vmware_guest instead of just
vmware_guest.

This way, the examples don't depend on the collections directive of the
playbook.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

vmware

@goneri
vmware: example should use FQCN
6b009c9 
For instance, you should use `community.vmware.vmware_guest` instead of just
`vmware_guest`.

This way, the examples don't depend on the `collections` directive of the
playbook.
@goneri goneri requested a review from Akasurde May 6, 2020 14:57
@goneri goneri mentioned this pull request May 6, 2020
Merged
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 6, 2020
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 6, 2020
goneri and others added 2 commits May 11, 2020 16:26
@goneri @samccann
Update docs/docsite/rst/dev_guide/platforms/vmware_guidelines.rst
e2f2fa0 
Co-authored-by: Sandra McCann <samccann@redhat.com>
@goneri @samccann
Update docs/docsite/rst/dev_guide/platforms/vmware_guidelines.rst
1cc2d2f 
Co-authored-by: Sandra McCann <samccann@redhat.com>
@goneri
Copy link
Contributor Author

goneri commented May 11, 2020

Thanks @samccann for the review.

@goneri goneri merged commit e70f5cc into ansible:devel May 11, 2020
@ansible ansible locked and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann left review comments

@pabelanger pabelanger pabelanger approved these changes

@Akasurde Akasurde Awaiting requested review from Akasurde

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@goneri @pabelanger @samccann @ansibot