Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix galaxy role info bug to support multiple roles #70148

Merged
merged 3 commits into from Jun 23, 2020

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Jun 18, 2020

SUMMARY

'ansible-galaxy role info' appears to have intended to support multiple roles being listed on the command line. It currently ignores all roles except the last. Fix that.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-galaxy

ADDITIONAL INFORMATION

Example output after the fix:

% ansible-galaxy role info --offline geerlingguy.docker geerlingguy.backup

Role: geerlingguy.docker
        description: Docker for Linux.
        dependencies: []
        galaxy_info:
                author: geerlingguy
                company: Midwestern Mac, LLC
                galaxy_tags: ['web', 'system', 'containers', 'docker', 'orchestration', 'compose', 'server']
                license: license (BSD, MIT)
                min_ansible_version: 2.4
                platforms: [{'name': 'EL', 'versions': [7, 8]}, {'name': 'Fedora', 'versions': ['all']}, {'name': 'Debian', 'versions': ['stretch', 'buster']}, {'name':
                role_name: docker
        install_date: Wed Jun 17 18:35:14 2020
        installed_version: 2.8.1
        path: ('/Users/shrews/.ansible/roles', '/usr/share/ansible/roles', '/etc/ansible/roles')

Role: geerlingguy.backup
        description: Backup for Simple Servers.
        dependencies: []
        galaxy_info:
                author: geerlingguy
                company: Midwestern Mac, LLC
                galaxy_tags: ['system', 'backup', 'resilience', 'storage', 'rsync', 'disaster', 'recovery']
                license: license (BSD, MIT)
                min_ansible_version: 2.4
                platforms: [{'name': 'EL', 'versions': ['all']}, {'name': 'GenericUNIX', 'versions': ['all']}, {'name': 'Fedora', 'versions': ['all']}, {'name': 'opensu
        install_date: Mon Jun 15 19:16:26 2020
        installed_version: 1.2.2
        path: ('/Users/shrews/.ansible/roles', '/usr/share/ansible/roles', '/etc/ansible/roles')

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 18, 2020
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jun 23, 2020
@samdoran
Copy link
Contributor

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. shipit This PR is ready to be merged by Core labels Jun 23, 2020
@samdoran samdoran merged commit dd07bdf into ansible:devel Jun 23, 2020
bcoca pushed a commit to bcoca/ansible that referenced this pull request Jun 25, 2020
@ansible ansible locked and limited conversation to collaborators Jul 21, 2020
@Shrews Shrews deleted the galaxy-role-info branch March 16, 2021 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants