Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To backport ios_user and ios_command TC failure fix #70253

Merged
merged 4 commits into from Jun 24, 2020
Merged

To backport ios_user and ios_command TC failure fix #70253

merged 4 commits into from Jun 24, 2020

Conversation

justjais
Copy link
Contributor

@justjais justjais commented Jun 24, 2020 •
edited

SUMMARY

To backport ios_user and ios_command TC failure fix. Backported from: ansible-collections/cisco.ios#82

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_user and ios_command

ADDITIONAL INFORMATION

@justjais justjais requested a review from samdoran June 24, 2020 06:06
@justjais justjais mentioned this pull request Jun 24, 2020
Merged
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies collection Related to Ansible Collections work collection:cisco.ios core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jun 24, 2020
@ansibot
Copy link
Contributor

ansibot commented Jun 24, 2020

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

changelogs/fragments/82_ios_user_ios_command_text_fix.yaml:4:1: empty-lines: too many blank lines (1 > 0)
test/integration/targets/ios_user/tests/cli/auth.yaml:36:11: error: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 24, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 24, 2020
@justjais
Copy link
Contributor Author

recheck

1 similar comment
@justjais
Copy link
Contributor Author

recheck

@mattclay mattclay merged commit d672ee1 into ansible:stable-2.9 Jun 24, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jun 26, 2020
@ansible ansible locked and limited conversation to collaborators Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran Awaiting requested review from samdoran

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies collection:cisco.ios collection Related to Ansible Collections work core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justjais @ansibot @sivel @mattclay