Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert commits related to delegated facts changes #70272

Merged
merged 2 commits into from Jun 24, 2020

Conversation

samdoran
Copy link
Contributor

SUMMARY

This reverts commit eaf6086 and 88bb76f.
These changes are causing CI failures because the known_hosts file is changing.

11:33 >>> Environment Diff
11:33 --- original.json
11:33 +++ current.json
11:33 @@ -1,5 +1,5 @@
11:33  {
11:33 -    "known_hosts_hash": "33e7e47234ad996e1b1ae448cebd575a", 
11:33 +    "known_hosts_hash": "e41a2154160d522a1e44a2f292768e1c", 

Example failure: https://app.shippable.com/github/ansible/ansible/runs/168986/45/console

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/action/__init__.py

ADDITIONAL INFORMATION

I'm still trying to determine why the tests for those PRs passed but are now causing failures in CI once merged. I'll provide more information when I have it.

@samdoran samdoran requested a review from mkrizek June 24, 2020 18:58
@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 24, 2020
@samdoran
Copy link
Contributor Author

The tests for the PR passed because they were run before I rebalanced the CI groups and moved the connection_ssh to another group. It used to be in the same group with delegate_to but now it is not.

The delegate_to test with the changes reverted here requires the connection_ssh test to run before the delegate_to test.

To duplicate the failure, run the delegate_to test by itself with just the changes in eaf6086.

ansible-test integration delegate_to connection_ssh --remote osx/10.11 -v --remote-terminate always

@samdoran
Copy link
Contributor Author

The second commit, 88bb76f, was only reverted because it was necessary to revert eaf6086 without merge conflicts.

bcoca pushed a commit to bcoca/ansible that referenced this pull request Jun 25, 2020
* Revert "Fix storing delegate_to facts (ansible#70231)"

This reverts commit 88bb76f.

* Revert "Fix storing local task_vars facts for the retry (ansible#70171)"

This reverts commit eaf6086.
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jun 26, 2020
@ansible ansible locked and limited conversation to collaborators Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants