Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update windows_winrm.rst #70306

Merged
merged 1 commit into from Jul 13, 2020
Merged

Update windows_winrm.rst #70306

merged 1 commit into from Jul 13, 2020

Conversation

mahadelmi
Copy link
Contributor

@mahadelmi mahadelmi commented Jun 25, 2020 •
edited by Akasurde

gcc also needed to be installed alongside python-devel, krb5-devel, krb5-libs, and krb5-workstation.

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@mahadelmi
Update windows_winrm.rst
3e9d276 
gcc also needed to be installed alongside python-devel, krb5-devel, krb5-libs, and krb5-workstation.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Jun 25, 2020
@acozine acozine removed the needs_triage Needs a first human triage before being processed. label Jun 25, 2020
Akasurde
Akasurde previously requested changes Jun 26, 2020
View reviewed changes
docs/docsite/rst/user_guide/windows_winrm.rst
@@ -303,7 +303,7 @@ Some system dependencies that must be installed prior to using Kerberos. The scr
.. code-block:: shell

# Via Yum (RHEL/Centos/Fedora)
yum -y install python-devel krb5-devel krb5-libs krb5-workstation
yum -y install gcc python-devel krb5-devel krb5-libs krb5-workstation

# Via Apt (Ubuntu)
sudo apt-get install python-dev libkrb5-dev krb5-user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think Ubuntu and derivatives also require gcc for python-devel? if yes, can you edit this line as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to add those because I assumed that it would be needed for all of them but I haven't tried to install kerberos/ansible on those machines so I wasn't sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link might help us with that question: requests/requests-kerberos#109

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 26, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 6, 2020
@acozine
Copy link
Contributor

acozine commented Jul 13, 2020

Thanks @mahadelmi for this PR, and for sharing your experience with the wider Ansible community through the documentation. Thanks @Akasurde for the review. I'm going to kick off a fresh CI run and merge this, since it is an improvement over what we have now. I'll also post the question of what Ubuntu and other linux flavors need to the #ansible-windows IRC channel.

@acozine acozine dismissed Akasurde’s stale review July 13, 2020 16:31

I'd like to get this improvement merged. I'll see if someone in #ansible-windows can help with the question of what Ubuntu users need.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 13, 2020
@acozine acozine merged commit f4ea43c into ansible:devel Jul 13, 2020
samccann pushed a commit to samccann/ansible that referenced this pull request Jul 16, 2020
@mahadelmi @samccann
Update windows_winrm.rst (ansible#70306)
7c6f17a 
gcc also needed to be installed alongside python-devel, krb5-devel, krb5-libs, and krb5-workstation.

(cherry picked from commit f4ea43c)
@samccann samccann mentioned this pull request Jul 16, 2020
Merged
acozine added a commit that referenced this pull request Jul 17, 2020
@samccann @michaelritsema
@tremble @mattclay @AlanCoding @FloMiau @mahadelmi @sayee-jadhav @goetzk @Akasurde @Andersson007 @bmillemathias @acozine
[backport][2.10]Docs backportapalooza3 (#70695)
c936b8b 
* Suggest ansible ad-hoc command while developing module (#70308)

If a local module has no documentation, the doc command will fail without any hints of what is wrong. Add another way to confirm the presence of a local module.
* Update docs/docsite/rst/dev_guide/developing_locally.rst

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 82e5d03)

* Update AWS Integration test docmentation (#70454)

(cherry picked from commit e1ba7dc)

* Update hacking/shippable docs.

The `--all` option downloads more than is needed for analyzing code coverage.

(cherry picked from commit fb7740a)

* Document that subversion module requires subversion (#70537)

(cherry picked from commit 64c2cb2)

* update documentation link to python 3 (#70509)

update the docs link for strftime on the filters page to point to the python3 docs

(cherry picked from commit f7db428)

* Update windows_winrm.rst (#70306)

gcc also needed to be installed alongside python-devel, krb5-devel, krb5-libs, and krb5-workstation.

(cherry picked from commit f4ea43c)

* updated requirements file for docs build (#70609)

(cherry picked from commit 38ccfb4)

* Clarify that index_var is 0 indexed (#70548)

A little further down the page is another index, ansible_loop.index, which shares a similar description but is 1 indexed.
Its zero indexed twin has a 0 suffix.

``ansible_loop.index``      The current iteration of the loop. (1 indexed)
``ansible_loop.index0``     The current iteration of the loop. (0 indexed)

To remove ambiguity around the usage of index_var, explicitly mention that this variable is 0 indexed.

(cherry picked from commit c410311)

* docs: update module development docs (#70594)

Update module development docs for flattened modules directory.

Fixes: #70261 (at least partially)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 20209c5)

* Doc: fix examples of changelog entries. (#70551)

(cherry picked from commit edcd1a1)

* Document tags are not supported with task meta. (#70590)

fixes #70338

(cherry picked from commit 40591d5)

* docs: update date format in removed_at_date (#70597)

removed_at_date requires YYYY-MM-DD format.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 375c6b4)

* partial update of community docs to reflect collections transition (#70488)

(cherry picked from commit f1f782f)

Co-authored-by: Michael Ritsema <michaelritsema@users.noreply.github.com>
Co-authored-by: Mark Chappell <mchappel@redhat.com>
Co-authored-by: Matt Clay <matt@mystile.com>
Co-authored-by: Alan Rominger <arominge@redhat.com>
Co-authored-by: FloMiau <37121807+FloMiau@users.noreply.github.com>
Co-authored-by: mahadelmi <mahadelmi@cmail.carleton.ca>
Co-authored-by: Sayee <57951841+sayee-jadhav@users.noreply.github.com>
Co-authored-by: Karl Goetz <goetzk@users.noreply.github.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Co-authored-by: Baptiste Mille-Mathias <baptiste.millemathias@gmail.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
@ansible ansible locked and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde left review comments

Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mahadelmi @acozine @Akasurde @ansibot