Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc collection metadata fixes #70403

Merged
merged 2 commits into from Jul 1, 2020
Merged

misc collection metadata fixes #70403

merged 2 commits into from Jul 1, 2020

Conversation

nitzmahone
Copy link
Member

SUMMARY
  • parse collection meta with libyaml if available (thanks @sivel!)
  • require only Mapping for validation
  • add explanatory text for _meta_yml_to_dict

2.10 backport candidate

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@nitzmahone
misc collection metadata fixes
be54716 
* parse collection meta with libyaml if available
* require only Mapping for validation
* add explanatory text for _meta_yml_to_dict
@nitzmahone nitzmahone requested a review from relrod June 30, 2020 22:48
@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 30, 2020
@ansibot
Copy link
Contributor

ansibot commented Jun 30, 2020

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/utils/collection_loader/_collection_meta.py:16:4: ansible-bad-import-from: Import Mapping from ansible.module_utils.common._collections_compat instead of collections

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 30, 2020
relrod
relrod approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@relrod relrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming lint fix.

@nitzmahone
ignore custom pylint rule
f9da273 
* this code shouldn't import a bunch of stuff from ansible, since it's run under the import sanity test
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 1, 2020
@bcoca bcoca merged commit b9e38e8 into ansible:devel Jul 1, 2020
nitzmahone added a commit to nitzmahone/ansible that referenced this pull request Jul 1, 2020
@nitzmahone
misc collection metadata fixes (ansible#70403)
aa3cd73 
* misc collection metadata fixes

* parse collection meta with libyaml if available
* require only Mapping for validation
* add explanatory text for _meta_yml_to_dict

* ignore custom pylint rule

* this code shouldn't import a bunch of stuff from ansible, since it's run under the import sanity test

(cherry picked from commit b9e38e8)
@nitzmahone nitzmahone mentioned this pull request Jul 1, 2020
Merged
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 6, 2020
nitzmahone added a commit that referenced this pull request Jul 17, 2020
@nitzmahone
misc collection metadata fixes (#70403) (#70428)
865ba19 
* misc collection metadata fixes

* parse collection meta with libyaml if available
* require only Mapping for validation
* add explanatory text for _meta_yml_to_dict

* ignore custom pylint rule

* this code shouldn't import a bunch of stuff from ansible, since it's run under the import sanity test

(cherry picked from commit b9e38e8)
@ansible ansible locked and limited conversation to collaborators Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@relrod relrod relrod approved these changes

Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nitzmahone @ansibot @relrod @sivel @bcoca