Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.10] ssh connection - use get_option() rather than _play_context (#70438) #70443

Merged
merged 1 commit into from Jul 17, 2020
Merged

[stable-2.10] ssh connection - use get_option() rather than _play_context (#70438) #70443

merged 1 commit into from Jul 17, 2020

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Jul 2, 2020

SUMMARY

Backport of #70438 for Ansible 2.10

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/connection/ssh.py

@samdoran
[stable-2.10] ssh connection - use get_option() rather than _play_con…
ded6d01 
…text (ansible#70438)

The ssh_args were sometimes not correctly applied to the connection
when using _play_context. Use get_option() instead to ensure the
correct ssh_args are always applied.
(cherry picked from commit b4184aa)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 2, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 10, 2020
@nitzmahone nitzmahone merged commit df3246b into ansible:stable-2.10 Jul 17, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 21, 2020
@ansible ansible locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samdoran @sivel @ansibot @nitzmahone