[2.9] puppet: Fix command line construction #70463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix command line construction in the puppet module related to check mode and using manifests directly. Also, fixes 69ead0b which introduced another if-statement in the middle of a if/elif pair, which causes the elif to execute together with the original if which created '--noop --no-noop' commands. Fixes: ansible#60576
This was referenced Jul 4, 2020
ansibot
added
affects_2.9
ansibot
added
the
stale_ci
Akasurde
changed the title
sivel
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix command line construction in the puppet module
related to check mode and using manifests directly.
Also, fixes 69ead0b which
introduced another if-statement in the middle of a if/elif pair,
which causes the elif to execute together with the original if
which created '--noop --no-noop' commands.
Fixes: #60576
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/114_puppet_quote.yml
lib/ansible/modules/system/puppet.py