Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR implements a few performance enhancements to our
ast.NodeVisitor
to speed up traversing the AST.getattr
generic_visit
to not callvisit
, eliminating function callsgeneric_visit
to not walkexpr
objects, as imports can only happen withinstmt
ISSUE TYPE
COMPONENT NAME
lib/ansible/executor/module_common.py
ADDITIONAL INFORMATION
cProfile of
recursive_finder
before this change:After: