command warnings: don't send the param from action #70531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
Change: - Followup to ansible#70504. We need to not pass the 'warn' parameter from the action plugin either, unless it's True. Otherwise, even though it defaults to false, we always show the deprecation. Test Plan: - Local Signed-off-by: Rick Elrod <rick@elrod.me>
relrod
force-pushed
the
modules/command/actionfix
branch
from
75b734f
to
38de567
Compare
ansibot
added
support:community
samdoran
approved these changes
Jul 9, 2020
ansibot
added
needs_revision
bcoca
reviewed
Jul 10, 2020
| @@ -17,7 +17,7 @@ def run(self, tmp=None, task_vars=None): | |||
| del tmp # tmp no longer has any effect | |||
|
|
|||
| # Command module has a special config option to turn off the command nanny warnings | |||
| if 'warn' not in self._task.args: | |||
| if 'warn' not in self._task.args and C.COMMAND_WARNINGS: | |||
There was a problem hiding this comment.
this changes the meaning, before we only set the configured default if it was not set in the task itself, now we only set it if the configured default is true.
what you really want is to set it if the configured default is explicit and not from 'default', so those setting it to 'false' in the configuration should also get a warning. (use get_config_value_and_origin to get both value and where it was set from)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Change:
action plugin either, unless it's True. Otherwise, even though it
defaults to false, we always show the deprecation.
Test Plan:
Signed-off-by: Rick Elrod rick@elrod.me
ISSUE TYPE
COMPONENT NAME
command, shell