Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt module get_xml command should support flags #70852

Closed
braindevices opened this issue Jul 23, 2020 · 3 comments
Closed

virt module get_xml command should support flags #70852

braindevices opened this issue Jul 23, 2020 · 3 comments
Labels
affects_2.11 cloud collection:community.libvirt collection Related to Ansible Collections work module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. support:community This issue/PR relates to code supported by the Ansible community. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox)

Comments

@braindevices
Copy link

SUMMARY

libvirt XMLDesc(flags) The flag is important, some time we want to have VIR_DOMAIN_XML_SECURE to get sensitive info. In most cases we want to use VIR_DOMAIN_XML_INACTIVE for running VMs, in some cases we want to get the live state. So far the module use flag=0 which is live one without sensitive data. We need to give an additional flag parameter for this.

ISSUE TYPE
  • add a flags parameter to pass into XMLDesc(), it can just be a list of int.
COMPONENT NAME

virt

ADDITIONAL INFORMATION

virt: command=get_xml flags=[...]
For example, if we want inactive state with sensitive info:

- virt:
    command: get_xml
    name: vm1
    flags:
       - 1
       - 2
@ansibot
Copy link
Contributor

ansibot commented Jul 23, 2020

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 23, 2020

@braindevices: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • ansible version

Please set the description of this issue with an appropriate template from:
https://github.com/ansible/ansible/tree/devel/.github/ISSUE_TEMPLATE

click here for bot help

@ansibot ansibot added affects_2.11 cloud collection Related to Ansible Collections work collection:community.libvirt module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Jul 23, 2020
@sivel
Copy link
Member

sivel commented Jul 23, 2020

Thank you very much for your interest in Ansible. This plugin is no longer maintained in this repository and has been migrated to https://github.com/ansible-collections/community.libvirt

Please re-submit this issue in the above repository.

If you have further questions please stop by IRC or the mailing list:

@sivel sivel closed this as completed Jul 23, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 24, 2020
@ansible ansible locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 cloud collection:community.libvirt collection Related to Ansible Collections work module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. support:community This issue/PR relates to code supported by the Ansible community. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox)
Projects
None yet
Development

No branches or pull requests

3 participants