Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changelog tool be more strict about suffixes #70909

Merged
merged 3 commits into from Aug 6, 2020

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Analogue to #70798 for devel (and stable-2.10). Bumps the antsibull-changelog version to 0.7.0, which includes a new option to be more strict about suffixes (ansible-community/antsibull-changelog#33), enables this option in changelogs/config.yaml, and adjusts the sanity test to flag all files that are not processed, with the exception of .keep and .gitkeep. (.keep and .gitkeep seem to be the most common ways of people making sure empty subdirectories are kept by git and other version control systems: https://stackoverflow.com/questions/7229885/what-are-the-differences-between-gitignore-and-gitkeep)

CC @relrod @mattclay

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

changelog
changelog sanity test

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 27, 2020
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jul 28, 2020
@samdoran
Copy link
Contributor

cc @mattclay

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 29, 2020
@felixfontein
Copy link
Contributor Author

cc @relrod

The updated version of antsibull-changelog is also needed for #71080.

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 4, 2020
@relrod relrod merged commit fbfc0f9 into ansible:devel Aug 6, 2020
@felixfontein felixfontein deleted the changelog branch August 6, 2020 21:59
@felixfontein
Copy link
Contributor Author

@relrod thanks for reviewing and merging!

felixfontein added a commit to felixfontein/ansible that referenced this pull request Aug 6, 2020
* Bump antsibull-changelog version.

* Flag all dotfiles, except .keep and .gitkeep.

* Enable ignoring other fragment extensions.

(cherry picked from commit fbfc0f9)
zoredache pushed a commit to zoredache/ansible that referenced this pull request Aug 10, 2020
* Bump antsibull-changelog version.

* Flag all dotfiles, except .keep and .gitkeep.

* Enable ignoring other fragment extensions.
nitzmahone pushed a commit that referenced this pull request Aug 21, 2020
* Bump antsibull-changelog version.

* Flag all dotfiles, except .keep and .gitkeep.

* Enable ignoring other fragment extensions.

(cherry picked from commit fbfc0f9)
@ansible ansible locked and limited conversation to collaborators Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants