New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make changelog tool be more strict about suffixes #70909
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
needs_triage
Needs a first human triage before being processed.
small_patch
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Jul 27, 2020
samdoran
removed
the
needs_triage
Needs a first human triage before being processed.
label
Jul 28, 2020
cc @mattclay |
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Jul 29, 2020
ansibot
added
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
and removed
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
labels
Aug 4, 2020
relrod
approved these changes
Aug 6, 2020
@relrod thanks for reviewing and merging! |
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Aug 6, 2020
* Bump antsibull-changelog version. * Flag all dotfiles, except .keep and .gitkeep. * Enable ignoring other fragment extensions. (cherry picked from commit fbfc0f9)
zoredache
pushed a commit
to zoredache/ansible
that referenced
this pull request
Aug 10, 2020
* Bump antsibull-changelog version. * Flag all dotfiles, except .keep and .gitkeep. * Enable ignoring other fragment extensions.
nitzmahone
pushed a commit
that referenced
this pull request
Aug 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.11
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
small_patch
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Analogue to #70798 for devel (and stable-2.10). Bumps the antsibull-changelog version to 0.7.0, which includes a new option to be more strict about suffixes (ansible-community/antsibull-changelog#33), enables this option in changelogs/config.yaml, and adjusts the sanity test to flag all files that are not processed, with the exception of
.keep
and.gitkeep
. (.keep
and.gitkeep
seem to be the most common ways of people making sure empty subdirectories are kept by git and other version control systems: https://stackoverflow.com/questions/7229885/what-are-the-differences-between-gitignore-and-gitkeep)CC @relrod @mattclay
ISSUE TYPE
COMPONENT NAME
changelog
changelog sanity test