Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit proper error for x in y when y is undefined #70990

Merged
merged 1 commit into from Jul 30, 2020
Merged

Emit proper error for x in y when y is undefined #70990

merged 1 commit into from Jul 30, 2020

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Jul 30, 2020

SUMMARY

Fixes #70984

See #70984 (comment) and #70984 (comment)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/template/__init__.py

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. files Files category needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 30, 2020
@acozine acozine added P3 Priority 3 - Approved, No Time Limitation and removed needs_triage Needs a first human triage before being processed. labels Jul 30, 2020
@samdoran samdoran merged commit bf7276a into ansible:devel Jul 30, 2020
@mkrizek mkrizek deleted the 70984-AnsibleUndefined-__contains__ branch July 31, 2020 06:36
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jul 31, 2020
@mkrizek
Emit proper error for x in y when y is undefined (ansible#70990)
140f21a 
Fixes ansible#70984

(cherry picked from commit bf7276a)
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jul 31, 2020
@mkrizek
Emit proper error for x in y when y is undefined (ansible#70990)
d357efd 
Fixes ansible#70984

(cherry picked from commit bf7276a)
This was referenced Jul 31, 2020
Merged
Merged
relrod pushed a commit that referenced this pull request Aug 6, 2020
@mkrizek
Emit proper error for x in y when y is undefined (#70990) (#71012)
4f732c9 
Fixes #70984

(cherry picked from commit bf7276a)
zoredache pushed a commit to zoredache/ansible that referenced this pull request Aug 10, 2020
@mkrizek @zoredache
Emit proper error for x in y when y is undefined (ansible#70990)
3419cce 
Fixes ansible#70984
@ansible ansible locked and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

@samdoran samdoran samdoran approved these changes

Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. files Files category P3 Priority 3 - Approved, No Time Limitation support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[template] unhelpful error message for x in y if y undefined
5 participants
@mkrizek @bcoca @samdoran @acozine @ansibot