Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ANSIBLE_COLLECTIONS_PATHS dep warning #71094

Merged
merged 1 commit into from Aug 4, 2020

Conversation

jborean93
Copy link
Contributor

SUMMARY

In Ansible 2.10 we added ANSIBLE_COLLECTIONS_PATH as the proper way of specifying a collection path and deprecated the plural form to conform to our usual standard of singular config options. Ultimately this means that for someone to support both 2.9 and 2.10 they need to use a config option that is deprecated and will output warnings saying not to.

This PR removes that deprecation for now and proposes it is added in the future once ANSIBLE_COLLECTIONS_PATH is supported in the oldest supported Ansible version or sometime close to that so they can be used in parallel.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ANSIBLE_COLLECTIONS_PATHS

@sivel sivel requested a review from nitzmahone August 4, 2020 19:26
@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 4, 2020
Copy link
Member

@sivel sivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with backing out the deprecation for 2.10.1

@jborean93 jborean93 merged commit aab9bec into ansible:devel Aug 4, 2020
@jborean93 jborean93 deleted the collections_path_dep branch August 4, 2020 21:38
jborean93 added a commit to jborean93/ansible that referenced this pull request Aug 4, 2020
@jborean93
Copy link
Contributor Author

Backport PR to stable-2.10 #71099.

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 6, 2020
zoredache pushed a commit to zoredache/ansible that referenced this pull request Aug 10, 2020
relrod pushed a commit that referenced this pull request Aug 27, 2020
@ansible ansible locked and limited conversation to collaborators Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants