Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: improve dev_guide/testing_integration.rst #71370

Merged
merged 5 commits into from Aug 20, 2020
Merged

Documentation: improve dev_guide/testing_integration.rst #71370

merged 5 commits into from Aug 20, 2020

Conversation

Andersson007
Copy link
Contributor

@Andersson007 Andersson007 commented Aug 20, 2020 •
edited

SUMMARY

Documentation: improve dev_guide/testing_integration.rst

  • use of -v option is a bit confusing in the examples. Looks like it relates to a tested module name.
  • improve the examples
  • actualize mentioned images
  • i don't see ubuntu1604py3 in the list of supported images, so removed
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/dev_guide/testing_integration.rst

@Andersson007
Copy link
Contributor Author

cc @felixfontein @mattclay

@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 20, 2020
@Andersson007
Copy link
Contributor Author

ready_for_review

mattclay
mattclay requested changes Aug 20, 2020
View reviewed changes
docs/docsite/rst/dev_guide/testing_integration.rst Outdated Show resolved Hide resolved
docs/docsite/rst/dev_guide/testing_integration.rst Outdated Show resolved Hide resolved
docs/docsite/rst/dev_guide/testing_integration.rst Outdated Show resolved Hide resolved
@Andersson007
Copy link
Contributor Author

@mattclay
ready_for_review

@Andersson007
Copy link
Contributor Author

cc @akcozine @samccann

@samccann samccann removed the needs_triage Needs a first human triage before being processed. label Aug 20, 2020
@samccann samccann merged commit 5498b0b into ansible:devel Aug 20, 2020
Andersson007 added a commit to Andersson007/ansible that referenced this pull request Aug 21, 2020
@Andersson007
Documentation: improve dev_guide/testing_integration.rst (ansible#71370)
963698a 
(cherry picked from commit 5498b0b)
@Andersson007 Andersson007 mentioned this pull request Aug 21, 2020
Merged
@Andersson007
Copy link
Contributor Author

@mattclay @samccann thanks for reviewing and merging!
created backport #71390

acozine pushed a commit that referenced this pull request Aug 21, 2020
@Andersson007
Documentation: improve dev_guide/testing_integration.rst (#71370) (#7…
72e9974 
…1390)

(cherry picked from commit 5498b0b)
@ansible ansible locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde left review comments

@mattclay mattclay mattclay approved these changes

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Andersson007 @Akasurde @mattclay @samccann @ansibot