Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.9] Fix ansible-doc's plugin name retrieval for text output #71965

Merged
merged 1 commit into from Sep 28, 2020
Merged

[2.9] Fix ansible-doc's plugin name retrieval for text output #71965

merged 1 commit into from Sep 28, 2020

Conversation

felixfontein
Copy link
Contributor

SUMMARY

This is NOT a backport. It is a 2.9-only fix, since the 2.10/devel code is sufficiently different.

Fixes the crash mentioned in #71795 (comment) and shows the correct plugin name.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-doc

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 27, 2020
@felixfontein
Copy link
Contributor Author

This is the 2.9 version of #71966.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 27, 2020
@felixfontein
Copy link
Contributor Author

/rebuild_failed

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Sep 27, 2020
@felixfontein
Copy link
Contributor Author

/rebuild_failed

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 28, 2020
@relrod relrod merged commit 35333e1 into ansible:stable-2.9 Sep 28, 2020
@felixfontein felixfontein deleted the 2.9-fix-ansible-doc branch September 28, 2020 15:26
@felixfontein
Copy link
Contributor Author

@relrod thanks for reviewing and merging!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Sep 29, 2020
@ansible ansible locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @sivel @relrod @ansibot