Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incidental_vyos_static_route #72024

Merged
merged 8 commits into from
Sep 30, 2020
Merged

Remove incidental_vyos_static_route #72024

merged 8 commits into from
Sep 30, 2020

Conversation

sivel
Copy link
Member

@sivel sivel commented Sep 30, 2020

SUMMARY

Remove incidental_vyos_static_route

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 30, 2020
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 30, 2020
@sivel sivel marked this pull request as ready for review September 30, 2020 20:02
@sivel sivel requested a review from mattclay September 30, 2020 20:02
@sivel sivel merged commit 9081b22 into ansible:devel Sep 30, 2020
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Oct 1, 2020
heiderich pushed a commit to heiderich/ansible that referenced this pull request Oct 4, 2020
@sivel @heiderich
Remove incidental_vyos_static_route (ansible#72024)
647763e 
* Add explicit tests for required_together suboptions

* ci_complete ci_coverage

* Remove incidental_vyos_static_route

* ci_complete ci_coverage

* Add explicit coverage of suboptions required_if

* ci_complete ci_coverage

* Remove incidental_vyos_logging

* ci_complete ci_coverage
mattclay pushed a commit to mattclay/ansible that referenced this pull request Oct 28, 2020
@sivel @mattclay
Remove incidental_vyos_static_route (ansible#72024)
9d98797 
* Add explicit tests for required_together suboptions

* ci_complete ci_coverage

* Remove incidental_vyos_static_route

* ci_complete ci_coverage

* Add explicit coverage of suboptions required_if

* ci_complete ci_coverage

* Remove incidental_vyos_logging

* ci_complete ci_coverage

(cherry picked from commit 9081b22)
@mattclay mattclay mentioned this pull request Oct 28, 2020
Merged
@ansible ansible locked and limited conversation to collaborators Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sivel @ansibot @mattclay @mkrizek