Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hint in doc of git module to abort on missing http password #72164

Merged
merged 2 commits into from
Nov 4, 2020
Merged

hint in doc of git module to abort on missing http password #72164

merged 2 commits into from
Nov 4, 2020

Conversation

SimonHeimberg
Copy link
Contributor

SUMMARY

Add a hint in doc of git module how to abort on missing http password.

improves #69489

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

git

ADDITIONAL INFORMATION

The example url is an unexisting repo on github, since this will trigger to ask for a password.

@SimonHeimberg SimonHeimberg mentioned this pull request Oct 9, 2020
Closed
@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. source_control Source-control category support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 9, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 17, 2020
sivel
sivel reviewed Oct 20, 2020
View reviewed changes
lib/ansible/modules/git.py Outdated Show resolved Hide resolved
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 20, 2020
@acozine
Copy link
Contributor

acozine commented Oct 20, 2020

@SimonHeimberg thanks for the docs PR! If you will commit sivel's suggestion above, which updates the example to use the preferred option: value syntax, I'll merge the PR (assuming it passes CI).

@SimonHeimberg @sivel
fix syntax in doc of git module
5557f6b 
Co-authored-by: Matt Martz <matt@sivel.net>
@SimonHeimberg
Copy link
Contributor Author

Hm, of course this is the correct syntax. I must have been tired. Thanks 🎁 for reviewing.

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 23, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 31, 2020
@acozine
Copy link
Contributor

acozine commented Nov 4, 2020

Thanks @SimonHeimberg!

@acozine
Copy link
Contributor

acozine commented Nov 4, 2020

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 4, 2020
@ansibot ansibot merged commit 7f86e07 into ansible:devel Nov 4, 2020
@ansible ansible locked and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel left review comments

Assignees
No one assigned
Labels
affects_2.11 docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. shipit This PR is ready to be merged by Core source_control Source-control category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SimonHeimberg @acozine @sivel @ansibot