Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ansible-test] Limit cryptography to <3.2 #72342

Merged
merged 2 commits into from Oct 26, 2020
Merged

[ansible-test] Limit cryptography to <3.2 #72342

merged 2 commits into from Oct 26, 2020

Conversation

relrod
Copy link
Member

@relrod relrod commented Oct 26, 2020

SUMMARY

Change:

  • Cryptography 3.2 drops support for OpenSSL 1.0.2. Some of our CI
    infrastructure still uses this version (FreeBSD, namely). For now,
    just add a constraint to use old cryptography.

Test Plan:

  • ci_complete

Signed-off-by: Rick Elrod rick@elrod.me

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

tests

@relrod
[ansible-test] Limit cryptography to <3.2
eb9cf34 
Change:
- Cryptography 3.2 drops support for OpenSSL 1.0.2. Some of our CI
  infrastructure still uses this version (FreeBSD, namely). For now,
  just add a constraint to use old cryptography.

Test Plan:
- ci_complete

Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Oct 26, 2020
@relrod
string
0bbc120 
Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 26, 2020
mattclay
mattclay approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@mattclay mattclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good short-term fix. Longer term we need to resolve the issues we're having with older FreeBSD releases and then update our CI config.

@relrod relrod merged commit 2293b32 into ansible:devel Oct 26, 2020
relrod added a commit to relrod/ansible that referenced this pull request Oct 26, 2020
@relrod
[ansible-test] Limit cryptography to <3.2 (ansible#72342)
8c35a51 
Change:
- Cryptography 3.2 drops support for OpenSSL 1.0.2. Some of our CI
  infrastructure still uses this version (FreeBSD, namely). For now,
  just add a constraint to use old cryptography.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
relrod added a commit that referenced this pull request Oct 26, 2020
@relrod
[ansible-test] Limit cryptography to <3.2 (#72342) (#72345)
4159c73 
Change:
- Cryptography 3.2 drops support for OpenSSL 1.0.2. Some of our CI
  infrastructure still uses this version (FreeBSD, namely). For now,
  just add a constraint to use old cryptography.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Oct 27, 2020
@ansible ansible locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

@samdoran samdoran Awaiting requested review from samdoran

Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@relrod @mattclay @bcoca @ansibot